Skip to content

[mono] Allow RuntimeType arguments in CustomAttributeBuilder - #58020

Merged
1 commit merged into
dotnet:mainfrom
uweigand:mono-customattrbuilder
Aug 27, 2021
Merged

[mono] Allow RuntimeType arguments in CustomAttributeBuilder#58020
1 commit merged into
dotnet:mainfrom
uweigand:mono-customattrbuilder

Conversation

@uweigand

Copy link
Copy Markdown
Contributor

@ghostghost added area-CoreLib-mono community-contribution Indicates that the PR has been added by a community member labels Aug 24, 2021
@jkotas

Copy link
Copy Markdown
Member

Do we need to add test?

@SamMonoRT

Copy link
Copy Markdown
Member

@uweigand - can we get a test added for the change ?

* Fixes#58019
* Also allow null Array value, and re-enable test case.
@uweigand

Copy link
Copy Markdown
ContributorAuthor

@uweigand - can we get a test added for the change ?

Turns out there was already a test case, but disabled on Mono. Re-enabling the test case showed the failure fixed by this PR originally, and it also fails because of another reason: the Mono implementation rejected a null field value of Array type, which CoreCLR accepts and the test case uses. I've added a fix for this second issue as well, and re-enabled the test case.

@ghost

Copy link
Copy Markdown

Hello @marek-safar!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
ghost merged commit 1630a67 into dotnet:mainAug 27, 2021
@uweigand
uweigand deleted the mono-customattrbuilder branch August 27, 2021 18:21
@srxqds

Copy link
Copy Markdown
Contributor

@marek-safar could this backport to release/6.0?

@lambdageek

Copy link
Copy Markdown
Member

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1177581011

@ghostghost locked as resolved and limited conversation to collaborators Sep 27, 2021
This pull request was closed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mono] CustomAttrBuilder does not support RuntimeType arguments

6 participants

@uweigand@jkotas@SamMonoRT@srxqds@lambdageek@marek-safar