Uh oh!
There was an error while loading. Please reload this page.
[mono] Allow RuntimeType arguments in CustomAttributeBuilder - #58020
Conversation
uweigand
commented
Aug 24, 2021
- Fixes[mono] CustomAttrBuilder does not support RuntimeType arguments #58019
jkotas
commented
Aug 24, 2021
Do we need to add test? |
SamMonoRT
commented
Aug 26, 2021
@uweigand - can we get a test added for the change ? |
* Fixes#58019 * Also allow null Array value, and re-enable test case.
uweigand
commented
Aug 27, 2021
Turns out there was already a test case, but disabled on Mono. Re-enabling the test case showed the failure fixed by this PR originally, and it also fails because of another reason: the Mono implementation rejected a null field value of Array type, which CoreCLR accepts and the test case uses. I've added a fix for this second issue as well, and re-enabled the test case. |
ghost
commented
Aug 27, 2021
Hello @marek-safar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me ( |
srxqds
commented
Aug 28, 2021
@marek-safar could this backport to release/6.0? |
lambdageek
commented
Aug 28, 2021
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1177581011 |