Skip to content

[wasm][debugger] Fixing assert while debugging. - #58028

Merged
thaystg merged 3 commits into
dotnet:mainfrom
thaystg:thays_fix_assert
Aug 24, 2021
Merged

[wasm][debugger] Fixing assert while debugging.#58028
thaystg merged 3 commits into
dotnet:mainfrom
thaystg:thays_fix_assert

Conversation

@thaystg

@thaystgthaystg commented Aug 24, 2021•
edited
Loading

Copy link
Copy Markdown
Member

When trying to evaluate DebuggerProxyAttribute of a generic type <T, K>, it was working only for one parameter .
Fixes#58021

@thaystg
thaystg requested a review from lewingAugust 24, 2021 15:31
@ghost

ghost commented Aug 24, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

When trying to evaluate DebuggerProxyAttribute of a generic type <T, K>, it was working only for one parameter .
Fixes #58021

TODO: Add a test case.

Author:thaystg
Assignees:-
Labels:

area-Debugger-mono

Milestone:-

@thaystg
thaystg requested review from radical and removed request for marek-safarAugust 24, 2021 16:13
@thaystg

thaystg commented Aug 24, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc1

@github-actions

github-actionsBot commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1163344818

@github-actionsgithub-actionsBot mentioned this pull request Aug 24, 2021
Merged
radical
radical reviewed Aug 24, 2021
View reviewed changes
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs
var genericTypeId = await GetTypeByName(sessionId, typeToSearch, token);
if (genericTypeId < 0)
return null;
methodId = await GetMethodIdByName(sessionId, genericTypeId, ".ctor", token);

@radicalradicalAug 24, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail to find the correct .ctor, if there is more than one on the type?

Also, DebuggerTypeProxy accepts a string arg with the type name. That doesn't have to be in this PR though.

radical
radical approved these changes Aug 24, 2021
View reviewed changes

@radicalradical left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments can be addressed in a separate PR. LGTM!

@thaystg
thaystg merged commit bfaa0fa into dotnet:mainAug 24, 2021
@lewing

lewing commented Aug 24, 2021

Copy link
Copy Markdown
Member

ci hit #58062

@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lewinglewinglewing approved these changes

Assignees

No one assigned

Labels

area-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasm][debugger] Assertion while debugging

3 participants

@thaystg@lewing@radical