Skip to content

[release/6.0] Additional statistics when a ServiceProvider is created - #58030

Merged
ericstj merged 1 commit into
release/6.0from
backport/pr-57753-to-release/6.0
Aug 24, 2021
Merged

[release/6.0] Additional statistics when a ServiceProvider is created#58030
ericstj merged 1 commit into
release/6.0from
backport/pr-57753-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 24, 2021•
edited by eerhardt
Loading

Copy link
Copy Markdown
Contributor

Backport of #57753 to release/6.0

/cc @eerhardt@allantargino

Customer Impact

We added a few diagnostics to DependencyInjection in 6.0 to help users debug / analyze their applications. This change adds 2 more stats to the information:

  • closedGenericsServices
  • openGenericsServices

Testing

New automated tests were written.

Risk

Low

@allantargino
Additional statistics when a ServiceProvider is created
f2a2806
* Number of open generics
* Number of closed generics
fix#52364
@ghost

ghost commented Aug 24, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #57753 to release/6.0

/cc @eerhardt@allantargino

Customer Impact

Testing

Risk

Author:github-actions[bot]
Assignees:-
Labels:

area-Extensions-DependencyInjection

Milestone:-

@eerhardt

eerhardt commented Aug 24, 2021

Copy link
Copy Markdown
Member

cc @danmoseley for approval

@eerhardteerhardt added this to the 6.0.0 milestone Aug 24, 2021
@danmoseley

danmoseley commented Aug 24, 2021

Copy link
Copy Markdown
Contributor

approved for release/6.0 -- low risk, augments diagnostics consistent with recent efforts in this area for 6.0

@ghost

ghost commented Aug 24, 2021

Copy link
Copy Markdown

Hello @eerhardt!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost

ghost commented Aug 24, 2021

Copy link
Copy Markdown

Apologies, while this PR appears ready to be merged, it looks like release/6.0 is a protected branch and I have not been granted permission to perform the merge.

1 similar comment
@ghost

ghost commented Aug 24, 2021

Copy link
Copy Markdown

Apologies, while this PR appears ready to be merged, it looks like release/6.0 is a protected branch and I have not been granted permission to perform the merge.

@ericstj
ericstj merged commit a83c78f into release/6.0Aug 24, 2021
@danmoseley
danmoseley deleted the backport/pr-57753-to-release/6.0 branch August 24, 2021 20:51
@ghostghost locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eerhardteerhardteerhardt approved these changes

Assignees

No one assigned

Labels

area-Extensions-DependencyInjection

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@eerhardt@danmoseley@ericstj@allantargino