Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc1] Support special characters in [JsonPropertyName] - #58075
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersAugust 24, 2021 22:40
ghost
commented
Aug 24, 2021
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsBackport of #58054 to release/6.0-rc1 /cc @steveharter Customer ImpactTestingRisk
|
eiriktsarpalis
approved these changes
Aug 25, 2021
lewing
commented
Aug 25, 2021
Member
Approved in email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58054 to release/6.0-rc1
/cc @steveharter
Fixes#57836
Customer Impact
Broken scenario: with source-gen, specifying a custom JSON property name through the
[JsonPropertyName(name)]attribute will cause a compile-time error ifnameis not a valid C# identifier, such as$valueorSmtp-Id. No feasible workaround although a custom converter could be authored to do that.Testing
A new test added to verify this scenario and the existing property name tests that run under the reflection-based serializer were modified to also under source-gen.
Risk
Low - changes are local to source-gen support of property names using
[JsonPropertyName].