Skip to content

Prevent AV in processinfo2 while suspended on Mono. - #58099

Merged
lateralusX merged 1 commit into
dotnet:mainfrom
lateralusX:lateralusX/fix-processinfo2-suspend-on-mono
Aug 26, 2021
Merged

Prevent AV in processinfo2 while suspended on Mono.#58099
lateralusX merged 1 commit into
dotnet:mainfrom
lateralusX:lateralusX/fix-processinfo2-suspend-on-mono

Conversation

@lateralusX

@lateralusXlateralusX commented Aug 25, 2021

Copy link
Copy Markdown
Member

#55379 only fixed CoreCLR. This commit makes similar fix in Mono as well, making sure
src/tests/tracing/eventpipe/diagnosticport runtime test pass on Mono.

@lateralusX
Prevent AV in processinfo2 while suspended on Mono.
87ddc8e
dotnet#55379 only fixed CoreCLR. This
commit makes similar fix in Mono as well, making sure
src/tests/tracing/eventpipe/diagnosticport runtime test pass on Mono.
@ghost

ghost commented Aug 25, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lateralusX

lateralusX commented Aug 25, 2021

Copy link
Copy Markdown
MemberAuthor

/CC @josalem

@lateralusX

lateralusX commented Aug 25, 2021•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@steveisok shouldn't we run runtime test suite on OSX as part of CI? This test, src/tests/tracing/eventpipe/diagnosticport/diagnosticport.cs, started to fail on all Mono platforms when #55379 was merged and that test is not included on the exclusion list, so it should run as part of CI and been caught before merge.

@lateralusX

lateralusX commented Aug 25, 2021

Copy link
Copy Markdown
MemberAuthor

Looks like the tests are not fully run since the test run is not setting COMPlus_TieredCompilation=0 causing tests to be skipped.

@lateralusX

lateralusX commented Aug 25, 2021

Copy link
Copy Markdown
MemberAuthor

This probably also need to apply to Mono,

runtime/eng/pipelines/common/templates/runtimes/run-test-job.yml

Line 375 in f97c18b

- ${{ if eq(parameters.runtimeFlavor, 'coreclr') }}:

@lateralusX

lateralusX commented Aug 25, 2021

Copy link
Copy Markdown
MemberAuthor

Enabling tests marked as JitOptimizationSensitive, #58106, should at least fail on the test fixed by this PR, but could fail on more since those test have also been skipped in previous runs.

@lateralusXlateralusX mentioned this pull request Aug 25, 2021
Merged
@lateralusX
lateralusX merged commit 1fa304a into dotnet:mainAug 26, 2021
@lateralusX

lateralusX commented Aug 26, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1169442484

@github-actionsgithub-actionsBot mentioned this pull request Aug 26, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarAwaiting requested review from marek-safar
1 more reviewer
@josalemjosalemjosalem approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Tracing-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lateralusX@josalem