Handle shadowed property names in DiagnosticsSourceEventSource

[josalem]

Fixes#57709

If a class, such as SqlLiteCommand, has a shadowed property name, such as SqlLiteCommand.Connection and DbCommand.Connection, the logic in DiagnosticSourceEventSource will throw an ambiguous match exception when trying to resolve a property with that name.

This patch adds a fast path for most use cases that will only check the declared properties on the given type and won't fall back to the looping logic unless it needs to.

This should be ported to 6.0-rc2 if approved.

[ghost]

Tagging subscribers to this area: @tommcdon, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #57709

If a class, such as SqlLiteCommand, has a shadowed property name, such as SqlLiteCommand.Connection and DbCommand.Connection, the logic in DiagnosticSourceEventSource will throw an ambiguous match exception when trying to resolve a property with that name.

This patch adds a fast path for most use cases that will only check the declared properties on the given type and won't fall back to the looping logic unless it needs to.

This should be ported to 6.0-rc2 if approved.

Author:	josalem
Assignees:	josalem
Labels:	area-System.Diagnostics
Milestone:	6.0.0

[josalem]

/backport to release/6.0

[josalem]

/backport to release/6.0

[github-actions]

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1171946310