Skip to content

Add Zero property to Quaternion. - #58406

Merged
danmoseley merged 9 commits into
dotnet:mainfrom
Takym:Quaternion2
Sep 1, 2021
Merged

Add Zero property to Quaternion.#58406
danmoseley merged 9 commits into
dotnet:mainfrom
Takym:Quaternion2

Conversation

@Takym

@TakymTakym commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

The difference with #57354 is that this PR does not contain IsZero property. This pull request resolves#57253.

@ghost

ghost commented Aug 30, 2021

Copy link
Copy Markdown

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghostghost added area-System.Numerics new-api-needs-documentation community-contribution Indicates that the PR has been added by a community member labels Aug 30, 2021
@ghost

ghost commented Aug 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

The difference with #57354 is that this PR does not contain IsZero property. This pull request resolves #57253.

Author:Takym
Assignees:-
Labels:

area-System.Numerics, new-api-needs-documentation, community-contribution

Milestone:-

danmoseley
danmoseley reviewed Aug 31, 2021
View reviewed changes
Comment threadsrc/libraries/System.Numerics.Vectors/ref/System.Numerics.Vectors.cs
public float Z;
public Quaternion(System.Numerics.Vector3 vectorPart, float scalarPart) { throw null; }
public Quaternion(float x, float y, float z, float w) { throw null; }
public static System.Numerics.Quaternion Zero { get { throw null; } }

@danmoseleydanmoseleyAug 31, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please generate this file? that will make it ordered, so next time we generate there won't be extra diffs. info:

runtime/docs/coding-guidelines/updating-ref-source.md

Line 16 in 57bfe47

1) Run `dotnet build --no-incremental /t:GenerateReferenceSource` from the System.Runtime/src directory.

danmoseley
danmoseley reviewed Aug 31, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Quaternion.cs
@stephentoubstephentoub mentioned this pull request Sep 1, 2021
Closed
stephentoub
stephentoub reviewed Sep 1, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Quaternion.cs Outdated
Takymand others added 2 commits September 1, 2021 12:34
@imhameedimhameed mentioned this pull request Sep 1, 2021
Merged
@danmoseley
danmoseley merged commit 32cbe96 into dotnet:mainSep 1, 2021
@danmoseley

danmoseley commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Thanks for the contribution @Takym . We would welcome more contributions from you.

@Takym
Takym deleted the Quaternion2 branch September 1, 2021 23:57
@ghostghost locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments
+1 more reviewer
@danmoseleydanmoseleydanmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Numericscommunity-contributionIndicates that the PR has been added by a community membernew-api-needs-documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Quaternion.Zero is missing

3 participants

@Takym@danmoseley@stephentoub