Skip to content

Fix X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException test on Android - #58441

Merged
akoeplinger merged 1 commit into
dotnet:mainfrom
akoeplinger:fix-android-crypto
Sep 1, 2021
Merged

Fix X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOutOfRangeException test on Android#58441
akoeplinger merged 1 commit into
dotnet:mainfrom
akoeplinger:fix-android-crypto

Conversation

@akoeplinger

@akoeplingerakoeplinger commented Aug 31, 2021•
edited
Loading

Copy link
Copy Markdown
Member

It started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02Z.
Since this test doesn't need to validate a specific expiration time we can just set the VerificationTime on the chain like we do in other tests.

Fixes#58416

@akoeplinger
Fix X509ChainElementCollection_CopyTo_NonZeroLowerBound_ThrowsIndexOu…
bd2a7fb
…tOfRangeException test on Android
It started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02.
Since this test doesn't need to validate a specific expiration time we can just set the VerificationTime on the chain like we do in other tests.
Fixesdotnet#58416
@ghost

ghost commented Aug 31, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

It started to fail because the validity of the MicrosoftDotComSslCertBytes expired on 2021-08-29 22:17:02.
Since this test doesn't need to validate a specific expiration time we can just set the VerificationTime on the chain like we do in other tests.

Fixes #58416

Author:akoeplinger
Assignees:-
Labels:

area-System.Security

Milestone:-

@akoeplingerakoeplinger mentioned this pull request Aug 31, 2021
Merged
@danmoseley

danmoseley commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Why is it affecting Android specifically?

@danmoseley

danmoseley commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

JSON tests failed with heap corruption?

@vcsjones

vcsjones commented Sep 1, 2021

Copy link
Copy Markdown
Member

Why is it affecting Android specifically?

Because Android's chain builder has OS specific behavior.

Other platforms, with an expired certificate, will at least build the chain and we get the chain back, plus an "it's expired" flag.

Android does not bother to build a chain for a an expired cert, it immediately bails out. So we don't get the chain collection back (thus the exception)

@akoeplinger
akoeplinger merged commit c156ebe into dotnet:mainSep 1, 2021
@akoeplinger
akoeplinger deleted the fix-android-crypto branch September 1, 2021 08:40
@akoeplinger

akoeplinger commented Sep 1, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

github-actionsBot commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1189440242

@github-actionsgithub-actionsBot mentioned this pull request Sep 1, 2021
Merged
@ghostghost locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@bartonjsbartonjsAwaiting requested review from bartonjs
+1 more reviewer
@filipnavarafilipnavarafilipnavara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[libraries][Android] System.Security.Cryptography.X509Certificates No IndexOutOfRangeException thrown

5 participants

@akoeplinger@danmoseley@vcsjones@filipnavara@stephentoub