Uh oh!
There was an error while loading. Please reload this page.
Don't always build source build with ci flag - #58457
Conversation
ghost
commented
Aug 31, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ViktorHofer
left a comment
There was a problem hiding this comment.
You will need to port these changes back into main as well. Same for the portable change that @dseefeld merged yesterday.
ViktorHofer
commented
Aug 31, 2021
@danmoseley should we treat source build work as tell-mode? |
danmoseley
commented
Aug 31, 2021
In my mind - yes. This counts as "Infrastructure work necessary to ship". cc @jeffschwMSFT in case he differs. |
ghost
commented
Aug 31, 2021
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsLocal dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.
|
MichaelSimons
commented
Sep 1, 2021
@ViktorHofer - Has all criteria been satisfied? If so please merge. |
Local dev builds should not normally be building source-build with the "ci" flag. The official builds/ci will set this appropriately. This change removes the "ci" flags for source-build.