Skip to content

Reflection nullability API: improve test coverage, fix bug found - #58479

Merged
buyaa-n merged 5 commits into
dotnet:mainfrom
buyaa-n:generics_nullability
Sep 11, 2021
Merged

Reflection nullability API: improve test coverage, fix bug found#58479
buyaa-n merged 5 commits into
dotnet:mainfrom
buyaa-n:generics_nullability

Conversation

@buyaa-n

@buyaa-nbuyaa-n commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Related to: #58390 (comment) cc @danmoseley

Reflection nullability context API updates

  • Improve test coverage by adding unused members into new/existing tests
  • Removed one unused member
  • fix a bug found in indexing generic type parameters

@buyaa-nbuyaa-n added this to the 6.0.0 milestone Sep 1, 2021
@buyaa-nbuyaa-n mentioned this pull request Sep 1, 2021
Merged
@danmoseley

danmoseley commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Seems it was worthwhile if you found a bug - great.

stephentoub
stephentoub reviewed Sep 1, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Reflection/NullabilityInfoContext.cs Outdated
steveharter
steveharter reviewed Sep 3, 2021
View reviewed changes
Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs Outdated
Comment threadsrc/libraries/System.Runtime/tests/System/Reflection/NullabilityInfoContextTests.cs
@buyaa-nbuyaa-n changed the title Reflection nullability API: improve test coverageReflection nullability API: improve test coverage, fix bug foundSep 3, 2021
@buyaa-n
buyaa-nforce-pushed the generics_nullability branch from 1608de1 to 027ceecCompareSeptember 3, 2021 20:29
@jeffhandley

jeffhandley commented Sep 8, 2021

Copy link
Copy Markdown
Member

@stephentoub I don't believe @steveharter is available to review this. Could you re-review please?

@buyaa-n

buyaa-n commented Sep 8, 2021

Copy link
Copy Markdown
ContributorAuthor

@stephentoub@steveharter comments addressed, please take another look

@buyaa-n
buyaa-n merged commit 8012edd into dotnet:mainSep 11, 2021
@buyaa-n
buyaa-n deleted the generics_nullability branch September 11, 2021 01:08
buyaa-n added a commit that referenced this pull request Sep 11, 2021
@buyaa-n
Reflection nullability API: improve test coverage, fix bug found (#58479
1bf4caf
)
* Add/remove some tests, fix generics indexing bug
Anipik pushed a commit that referenced this pull request Sep 14, 2021
@github-actions@buyaa-n
[release/6.0] Set generic type arguments nullability for value types (#…
f860bce
…58390)
* Set generic type arguments nullability for value types
* Skip test on mono
* Apply commment
* Separate var name parts with _
* Reflection nullability API: improve test coverage, fix bug found (#58479)
* Add/remove some tests, fix generics indexing bug
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
@ghostghost locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@krwqkrwqAwaiting requested review from krwq
@danmoseleydanmoseleyAwaiting requested review from danmoseley
@joperezrjoperezrAwaiting requested review from joperezr
@stevehartersteveharterAwaiting requested review from steveharter

Assignees

No one assigned

Labels

area-System.Reflection

Projects

No open projects
Triage POD for Reflection, META, etc.
Status: Done

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@buyaa-n@danmoseley@jeffhandley@stephentoub@steveharter