Convert the check for stdatomic.h into a compile step as opposed to existence check - #58532
Merged
1 commit merged intoSep 2, 2021
Merged
Convert the check for stdatomic.h into a compile step as opposed to existence check#585321 commit merged into
1 commit merged into
Conversation
to an existance check. This is done because MSVC's STL provides the file as compilable for C++23 but not currently for C11/C17.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThis is done because MSVC's STL provides the file as compilable for C++23 but not currently for C11/C17. Fixes #57618 /cc @jkoritzinsky
|
jkoritzinsky
approved these changes
Sep 1, 2021
hoyosjs
approved these changes
Sep 1, 2021
|
Hello @AaronRobinsonMSFT! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done because MSVC's STL provides the file as compilable for C++23 but not currently for C11/C17.
I was able to confirm locally the proposed fix in the issue - #57618.
Fixes #57618
/cc @jkoritzinsky