Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Notify Reference Tracker runtime of disconnect at the right time - #58533
Merged
Merged
Conversation
Based on misunderstanding of SyncBlock clean-up modes the indication of when an Native Object Wrapper was being collected was being done after the wrapper's Finalizer was run. However, this information must be conveyed prior to wrapper finalization and synchronously during the GC.
AaronRobinsonMSFT
commented
Sep 2, 2021
Member
/cc @jeffschwMSFT |
jeffschwMSFT
approved these changes
Sep 2, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and we can merge.
elinor-fung
approved these changes
Sep 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58472 to release/6.0
/cc @elinor-fung@AaronRobinsonMSFT
Customer Impact
Testing
Risk