Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] In reset_memory, check settings.entry_memory_load ... - #58543
Merged
Conversation
…w_memory_status - it looks like the latter won't be set on Linux.
…_high_memory_load_p.
ghost
commented
Sep 2, 2021
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of #58350 to release/6.0 /cc @PeterSolMS Customer ImpactTestingRisk
|
jeffschwMSFT
approved these changes
Sep 2, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and then we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58350 to release/6.0
/cc @PeterSolMS
Customer Impact
We had introduced to not reset large free blocks in .NET Core 5.0, unless memory usage is high. Unfortunately, the detection of high memory usage does not work correctly on Linux - this change fixes it. This change also refactors similar logic for decommitting parts of regions into a common helper method.
Testing
Verified that the change works correctly in the debugger.
Risk
Low - this is more of a tuning change.