Uh oh!
There was an error while loading. Please reload this page.
Skip eventpipe_readevents for arm32 - #58545
Conversation
Originally there was only one eventpipe test, and eventpipe_readevents was added in dotnet#37002. Both should be skipped for the same reason.
tommcdon
commented
Sep 27, 2021
josalem
commented
Sep 27, 2021
@davmason is there any reason we would need to disable eventpipe profiler tests on arm32 but not regular eventpipe tests? I would expect TraceEvent alignment issues to affect all variants of EventPipe tests. |
davmason
commented
Sep 27, 2021
The profiler tests construct EventPipe data blobs manually, so it's possible the tests themselves are hitting alignment issues not seen in TraceEvent. I don't know if that's what happening, but it is a potential difference. |
davmason
commented
Oct 29, 2021
@gbalykov is this still necessary? |
gbalykov
commented
Oct 29, 2021
I think so, I do not see any changes in main branch related to this |
tommcdon
commented
Nov 22, 2021
Thanks for the contribution @gbalykov! I'm merging this PR. According to runfo we have a couple of test failures in the last week on arm, and so we should disable the failing test while we investigate the failures.
|
Originally there was only one eventpipe test, and eventpipe_readevents was added in #37002.
Both should be skipped for the same reason.
cc @alpencolt