Uh oh!
There was an error while loading. Please reload this page.
Fix source-build on the s390x platform - #58553
Merged
Merged
Conversation
* Do not disable Mono in source-build if it is the primary runtime
ghost
commented
Sep 2, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
uweigand
commented
Sep 2, 2021
ContributorAuthor
crummel
approved these changes
Sep 2, 2021
ViktorHofer
commented
Sep 2, 2021
Member
I'm probably not the right person to review this as it's runtime and mono specific. @akoeplinger can you please take a look? |
akoeplinger
approved these changes
Sep 3, 2021
akoeplinger
commented
Sep 3, 2021
Member
/backport to release/6.0 |
Contributor
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1197682294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a build failure when building runtime via the source-build method on s390x: with source-build, the Mono runtime is currently not supported -- but this doesn't make sense on s390x where Mono is the primary (only) supported runtime.