Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Pass a null getter\setter with [JsonIgnore] and src gen - #58572
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersSeptember 2, 2021 16:56
ghost
commented
Sep 2, 2021
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsBackport of #58405 to release/6.0 /cc @steveharter Customer ImpactTestingRisk
|
steveharter
approved these changes
Sep 2, 2021
danmoseley
commented
Sep 3, 2021
Contributor
approved. low risk fix to new feature, customer reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58405 to release/6.0
Fixes#58320
/cc @steveharter
Customer Impact
Using both
[obsolete]and[JsonIgnore]on a property of a serializable POCO with the source generator causes a CS0618 compile warning due to the obsolete property being referenced by generated code. This was reported by the community.Testing
A test was added to verify this case; the source generator no longer references the property setter\getter.
Risk
Low; code changes are small and localized to the generation of the delegate to the setter\getter.