Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Undo struct promotion on "RetInd" code path - #58602
Merged
Conversation
This reverts commit 9ef80ba.
ghost
commented
Sep 3, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #58582 to release/6.0 /cc @kunalspathak Customer ImpactTestingRisk
|
kunalspathak
commented
Sep 3, 2021
Contributor
@dotnet/jit-contrib , @AndyAyersMS |
AndyAyersMS
approved these changes
Sep 3, 2021
JulieLeeMSFT
commented
Sep 3, 2021
Member
cc @jeffschwMSFT to backport to 6.0. |
Anipik
commented
Sep 7, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58582 to release/6.0
/cc @kunalspathak
Customer Impact
When struct's field is passed by reference, any update made to the
refvariable doesn't change the original value of struct's field. Additionally, if try to retrieve the value of the parameter, it returns wrong result.Testing
The fix contains a test.
Risk
Low, the issue arises in very specific scenario when we decide to promote struct, later undo the promotion and one of the field is used as return result.