Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix source generation support for tuples with explicitly named elements - #58723
Merged
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersSeptember 6, 2021 12:00
steveharter
approved these changes
Sep 7, 2021
danmoseley
commented
Sep 7, 2021
Contributor
Approved for release/6.0 -- customer reported, new feature, low risk/localized, we knew SG would have a tail as they got wider use. |
danmoseley
commented
Sep 7, 2021
Contributor
Will merge when OSX is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58644 to release/6.0
/cc @eiriktsarpalis
Customer Impact
Customer reported bug. Source generators are currently not value tuples with explicitly named elements properly, resulting in compile-time errors in the generated code. This can break source generation for any DTO containing value tuple properties (even if a
JsonIgnoreattribute has been applied by the user).Testing
Testing has been added to validate the broken scenario.
Risk
Low. Product code is a simple fix adding a missed clause in the field symbol filtering logic.