Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Support duplicated type names with src gen - #58766
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersSeptember 7, 2021 20:02
ghost
commented
Sep 7, 2021
Tagging subscribers to this area: @eiriktsarpalis, @layomia Issue DetailsBackport of #58448 to release/6.0 /cc @steveharter Customer ImpactTestingRisk
|
steveharter
approved these changes
Sep 8, 2021
Anipik
commented
Sep 8, 2021
Contributor
cc @danmoseley |
danmoseley
commented
Sep 8, 2021
Contributor
Approved. Value: Change increases likelihood customers will not fail with this new tech.. Risk: Changes only affect source gen. Roslyn changes reviewed by Sam. Automated tests added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58448 to release/6.0
Addresses #57349 for the System.Text.Json generator
Customer Impact
Support an edge case where a given type (by full name) can exist in more than one location. Without this change, any duplicated Types are not generated (the non-wrapped API returns
nullwhen there are conflicts). This allows thepublicversion of a Type to be returned over theinternalversion of the Type, for example.The corresponding issue and code was provided by the Roslyn team. The code wraps the API that resolves a Type name to a Type in order to allow
publicto win overinternal, for example.Testing
A test was added that duplicates types by name. The test failed before the changes were made.
Risk
Low - the corresponding code was provided by Roslyn and was previously tested. In the future, new API(s) will likely be exposed by Roslyn to address this scenario more fully and then this code can be removed.