Uh oh!
There was an error while loading. Please reload this page.
[tasks] [net472] Add ProjectReferences to JsonToItemsTaskFactory - #58825
Merged
Conversation
ghost
commented
Sep 8, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
lambdageek
commented
Sep 8, 2021
MemberAuthor
We will need to backport this to 6.0, I think. |
Reference the same versions of System.Threding.Tasks.Extensions and System.Text.Json that MSBuild in Visual Studio 2022 uses. Fixes build errors on maui-ios (and possibly blazorwasm) targets on Windows like: ``` System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask`1<!!0> System.Text.Json.JsonSerializer.DeserializeAsync(System.IO.Stream, System.Text.Json.JsonSerializerOptions, System.Threading.CancellationToken)'. at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.<GetJsonAsync>d__24.MoveNext() at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.GetJsonAsync(String jsonFilePath, FileStream file) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.TryGetJson(String jsonFilePath, JsonModelRoot& json) at JsonToItemsTaskFactory.JsonToItemsTaskFactory.JsonToItemsTask.Execute() at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() ``` from `C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.MonoTargets.Sdk\6.0.0-rc.1.21451.13\Sdk\RuntimeComponentManifest.targets`
lambdageek
commented
Sep 8, 2021
MemberAuthor
@ViktorHofer@steveisok@akoeplinger Should I make some I'm concerned a |
lambdageekforce-pushed
the
fix-json-netframework
branch
from
September 8, 2021 19:51
5bcba3d to
3b31901Comparelambdageekforce-pushed
the
fix-json-netframework
branch
from
September 9, 2021 13:13
0aae9f3 to
b919de0Comparesteveisok
approved these changes
Sep 10, 2021
lambdageek
commented
Sep 10, 2021
MemberAuthor
/backport to release/6.0 |
Contributor
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1219721635 |
Comment on lines
+20
to
+21
| <PackageReference Include="System.Threading.Tasks.Extensions" Version="4.5.4" PrivateAssets="all" /> | ||
| <PackageReference Include="System.Text.Json" Version="5.0.0" PrivateAssets="all" /> |
Contributor
There was a problem hiding this comment.
The version numbers should not be hardcoded here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference the same versions of System.Threding.Tasks.Extensions and System.Text.Json that MSBuild in Visual Studio 2022 uses.
Fixes build errors on maui-ios (and possibly blazorwasm) targets on Windows like:
from
C:\Program Files\dotnet\packs\Microsoft.NET.Runtime.MonoTargets.Sdk\6.0.0-rc.1.21451.13\Sdk\RuntimeComponentManifest.targetsUltimately this is because msbuild has a binding redirect here:
https://github.com/dotnet/msbuild/blob/1a1f20e4980fd1b02426b62220480f86e6ec5abf/src/MSBuild/app.config#L97
that points to an older version of System.Threading.Tasks.Extensions than what they end up building with, but that happens to coincide with the one that the JsonToItemsTaskFactory task bundles.
Related PR dotnet/msbuild#6830