Skip to content

[release/6.0] Fix publishing symbols for dotnet and hostpolicy - #58902

Merged
jeffschwMSFT merged 2 commits into
release/6.0from
backport/pr-58844-to-release/6.0
Sep 10, 2021
Merged

[release/6.0] Fix publishing symbols for dotnet and hostpolicy#58902
jeffschwMSFT merged 2 commits into
release/6.0from
backport/pr-58844-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 9, 2021

Copy link
Copy Markdown
Contributor

Backport of #58844 to release/6.0

/cc @elinor-fung

Customer Impact

Users cannot get symbols for dotnet or hostpolicy when trying to debug a .NET application.

Testing

Fix is in main for 7.0. Official runtime build with the fix has uploaded symbol packages and published symbols (build promotion) - verified symbols could be found using dotnet symbol.

Risk

Low. The fix updates the the output location for relevant symbol packages, such that they are uploaded / published.

@ghost

ghost commented Sep 9, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Comment threadsrc/installer/pkg/projects/Directory.Build.targets Outdated
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@ghost

ghost commented Sep 9, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #58844 to release/6.0

/cc @elinor-fung

Customer Impact

Users cannot get symbols for dotnet or hostpolicy when trying to debug a .NET application.

Testing

Fix is in main for 7.0. Official runtime build with the fix has uploaded symbol packages and published symbols (build promotion) - verified symbols could be found using dotnet symbol.

Risk

Low. The fix updates the the output location for relevant symbol packages, such that they are uploaded / published.

Author:github-actions[bot]
Assignees:-
Labels:

area-Host

Milestone:-

@elinor-fungelinor-fung added this to the 6.0.0 milestone Sep 9, 2021

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Once we have a green CI we can merge.

@jeffschwMSFT
jeffschwMSFT merged commit 36052e9 into release/6.0Sep 10, 2021
@akoeplinger
akoeplinger deleted the backport/pr-58844-to-release/6.0 branch September 10, 2021 16:02
@ghostghost locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jkoritzinsky@am11@jeffschwMSFT@elinor-fung