Skip to content

[release/6.0] Enhance CrossGen2 to emit PerfMap debug directory entry - #58929

Merged
jeffschwMSFT merged 1 commit into
dotnet:release/6.0from
hoyosjs:juhoyosa/fix-r2rmap-guid-6.0
Sep 10, 2021
Merged

[release/6.0] Enhance CrossGen2 to emit PerfMap debug directory entry#58929
jeffschwMSFT merged 1 commit into
dotnet:release/6.0from
hoyosjs:juhoyosa/fix-r2rmap-guid-6.0

Conversation

@hoyosjs

Copy link
Copy Markdown
Member

This is used to correlate PE's with their corresponding PerfMaps. For example the header in the perfmap could be:

FFFFFFFF 00 026D4D21B3EE3D93843FF7A964235822
FFFFFFFE 00 1
FFFFFFFD 00 1
FFFFFFFC 00 3
FFFFFFFB 00 1

And the PE will have the corresponding entries in the PE as:

PerfMap (Type 21):
System.Private.CoreLib.ni.r2rmap, Signature = 026d4d21b3ee3d93843ff7a964235822, Version = 1

Port of #58552 without unnecessary changes.

This is used to correlate PE's with their corresponding PerfMaps. For example the header in the perfmap could be:
```
FFFFFFFF 00 026D4D21B3EE3D93843FF7A964235822
FFFFFFFE 00 1
FFFFFFFD 00 1
FFFFFFFC 00 3
FFFFFFFB 00 1
```
And the PE will have the corresponding entries in the PE as:
```
PerfMap (Type 21):
System.Private.CoreLib.ni.r2rmap, Signature = 026d4d21b3ee3d93843ff7a964235822, Version = 1
```
@ghostghost added the area-ReadyToRun label Sep 10, 2021
@hoyosjshoyosjs self-assigned this Sep 10, 2021

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jeffschwMSFT
jeffschwMSFT merged commit 6a7fbec into dotnet:release/6.0Sep 10, 2021
@hoyosjs
hoyosjs deleted the juhoyosa/fix-r2rmap-guid-6.0 branch September 10, 2021 20:21
@ghostghost locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hoyosjs@jeffschwMSFT@trylek