Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Use separate VNs for DBL2INT_OVF helpers - #58931
Merged
Conversation
ghost
commented
Sep 10, 2021
Tagging subscribers to this area: @JulieLeeMSFT |
jeffschwMSFT
approved these changes
Sep 10, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. Please get a code review and then we can merge.
EgorBo
commented
Sep 10, 2021
Member
PTAL @dotnet/jit-contrib |
AndyAyersMS
approved these changes
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58868 to release/6.0
/cc @EgorBo
Customer Impact
In some specific cases
checkedcasts from float/double to any integer type might not throwOverflowExceptionwhere they should (see the test-case as an example)Testing
The fix contains a test
Risk
Low, it may only affect code where we mix
checkedanduncheckedcontexts for float-to-integer conversions./cc @dotnet/jit-contrib @AndyAyersMS