Skip to content

Revert changes from #58314 breaking build on FreeBSD. - #59004

Merged
jkotas merged 1 commit into
dotnet:mainfrom
josteink:main
Sep 12, 2021
Merged

Revert changes from #58314 breaking build on FreeBSD.#59004
jkotas merged 1 commit into
dotnet:mainfrom
josteink:main

Conversation

@josteink

Copy link
Copy Markdown
Member

PR #58314 replaced some build-configuration files tweaked by the FreeBSD community in order to make .NET build on FreeBSD.

PR dotnet/arcade#7885 fixes these changes upstream in dotnet/arcade to prevent future regressions, but we still need to revert the changes in runtime too, to make the build run.

CC: @jkotas@Thefrank

@ghostghost added area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member labels Sep 12, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

PR #58314 replaced some build-configuration files tweaked by the FreeBSD community in order to make .NET build on FreeBSD.

PR dotnet/arcade#7885 fixes these changes upstream in dotnet/arcade to prevent future regressions, but we still need to revert the changes in runtime too, to make the build run.

CC: @jkotas@Thefrank

Author:josteink
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@Thefrank

Copy link
Copy Markdown
Contributor

Thanks again for getting this fixed!

@josteink

Copy link
Copy Markdown
MemberAuthor

I'm pretty sure most of the CI-failures here are temporal and due to errors on the agent.

Can anyone re-queue the build? 😄

@jkotas
jkotas merged commit a90eba4 into dotnet:mainSep 12, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-librariescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@josteink@Thefrank@jkotas