Uh oh!
There was an error while loading. Please reload this page.
Remove SupportedOSPlatforms windows on Hosting WindowsServices - #59039
Conversation
ghost
commented
Sep 13, 2021
Tagging subscribers to this area: @eerhardt, @maryamariyan |
danmoseley
commented
Sep 13, 2021
failures are #58927 |
jeffhandley
left a comment
There was a problem hiding this comment.
Looks good to me.
Per an email conversation, this change sets the precedent that we can omit attributes in cases where the API connotes the platform support by name or docs summary, and no-ops on other platforms.
buyaa-n
left a comment
There was a problem hiding this comment.
Per an email conversation, this change sets the precedent that we can omit attributes in cases where the API connotes the platform support by name or docs summary, and no-ops on other platforms.
I wonder what if the developer doesn't know the API was no-op for other platforms, but for this assembly, it looks good to me as the assembly name indicates it is for Windows only
eerhardt
commented
Sep 13, 2021
Merging. Failures are infrastructure and flaky networking. |
eerhardt
commented
Sep 13, 2021
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1231195784 |
Fix#59037