Skip to content

Remove exception messages from resource strings - #59104

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:remove-exception-res-strings
Sep 15, 2021
Merged

Remove exception messages from resource strings#59104
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:remove-exception-res-strings

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Sep 14, 2021

Copy link
Copy Markdown
Member

Cherry picks the change fcb684e introduced in #59097 back to main.

@eiriktsarpaliseiriktsarpalis added this to the 7.0.0 milestone Sep 14, 2021
@eiriktsarpaliseiriktsarpalis self-assigned this Sep 14, 2021
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

Cherry picks the change introduced #59097.

Author:eiriktsarpalis
Assignees:eiriktsarpalis
Labels:

area-System.Text.Json

Milestone:7.0.0

@layomialayomia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley

Copy link
Copy Markdown
Contributor

Approved. Customers currently rely on exception messages being unlocalized. Low risk.

would not meet the bar after today.

@danmoseleydanmoseley added the Servicing-approved Approved for servicing release label Sep 15, 2021
@eiriktsarpalis
eiriktsarpalis merged commit 82993d2 into dotnet:mainSep 15, 2021
@eiriktsarpalis
eiriktsarpalis deleted the remove-exception-res-strings branch September 15, 2021 18:20
@eiriktsarpaliseiriktsarpalis removed the Servicing-approved Approved for servicing release label Sep 16, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@eiriktsarpalis@danmoseley@layomia