Skip to content

Undo breaking change compat in GetMethodNativeMap - #59114

Merged
hoyosjs merged 2 commits into
mainfrom
juhoyosa/fix-maps-dac-usage
Sep 16, 2021
Merged

Undo breaking change compat in GetMethodNativeMap#59114
hoyosjs merged 2 commits into
mainfrom
juhoyosa/fix-maps-dac-usage

Conversation

@hoyosjs

@hoyosjshoyosjs commented Sep 14, 2021

Copy link
Copy Markdown
Member

Introduced by #57176 for the case where address == 0. This just reverts to the old behavior in that case.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Introduced by https://github.com/dotnet/runtime/pull/57176/files for the case where address == 0. This just reverts to the old behavior in that case.

Author:hoyosjs
Assignees:hoyosjs
Labels:

area-Diagnostics-coreclr

Milestone:-

@mikem8361

Copy link
Copy Markdown
Contributor

Issue from VS: #59109

@hoyosjshoyosjs linked an issue Sep 14, 2021 that may be closed by this pull request
@hoyosjs
hoyosjs marked this pull request as ready for review September 14, 2021 22:15
@hoyosjs
hoyosjs merged commit 7017817 into mainSep 16, 2021
@hoyosjs
hoyosjs deleted the juhoyosa/fix-maps-dac-usage branch September 16, 2021 11:37
@hoyosjs

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1241401859

@hoyosjs

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc2

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1243309549

@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IXCLRDataMethodInstance.GetILAddressMap is broken in .NET 6 RC1

2 participants

@hoyosjs@mikem8361