Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] WasmAppBuilder: publish only once per target framework instead of invoking publish explicitly. - #59136
Merged
Conversation
danmoseley
approved these changes
Sep 15, 2021
danmoseley
left a comment
Contributor
There was a problem hiding this comment.
I don't really have enough context to approve but this is breaking CI and if this it we should get it merged ASAP
danmoseley
commented
Sep 15, 2021
Contributor
After the validation completes of course. Thanks for fixing.. |
radical
commented
Sep 15, 2021
MemberAuthor
I'm hoping that this fixes it! |
.. explcitly invoking `Publish`. Based on @ericstj's suggestion dotnet#58816 (comment) . Fixesdotnet#58816 .
radicalforce-pushed
the
fix-wasmappbuilder-6.0
branch
from
September 15, 2021 07:19
a01d479 to
4d2eab4Compareradical
marked this pull request as ready for review
September 15, 2021 08:22
marek-safar
approved these changes
Sep 15, 2021
danmoseley
commented
Sep 15, 2021
Contributor
Did this break originally get through PR validation just by bad luck? |
radical
commented
Sep 15, 2021
MemberAuthor
Yeah, race, and it happened to pass for all the builds that time 😬 |
radical added a commit
to radical/runtime
that referenced
this pull request
Sep 15, 2021
…instead of invoking publish explicitly. (dotnet#59136) (cherry picked from commit 5d03338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on @ericstj's suggestion
#58816 (comment) .
Fixes#58816 .