Uh oh!
There was an error while loading. Please reload this page.
Only set path in x64 mac installer when installing on x64 - #59210
Merged
Conversation
In other words don't set the path for x64 installer on ARM64
ericstj
requested review from
NikolaMilosavljevic, jkoritzinsky, sfoslund and vitek-karasSeptember 16, 2021 16:51
jkoritzinsky
approved these changes
Sep 16, 2021
ericstj
commented
Sep 16, 2021
MemberAuthor
@richlander let me know that he'd like us to write |
sfoslund
approved these changes
Sep 16, 2021
ericstj
commented
Sep 16, 2021
MemberAuthor
@jkoritzinsky or @vitek-karas do either of you know why we would need the postinstall script in both host and hostfxr? Do those ever get deployed seperately? |
There should be no need for both the host and hostfxr to set the path to dotnet. Since the host installs dotnet, it should be the only package responsible for this.
am11
reviewed
Sep 17, 2021
Uh oh!
There was an error while loading. Please reload this page.
Also refactor script to use a template so that we don't need to fork the script.
am11
reviewed
Sep 17, 2021
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
ericstj
commented
Sep 17, 2021
MemberAuthor
Since this commit was significantly changed since first approval, can I get a re-review? We'd like to get this in and ported back to 6.0. |
sfoslund
approved these changes
Sep 17, 2021
ericstj added a commit
to ericstj/runtime
that referenced
this pull request
Sep 18, 2021
* Only set path in x64 mac installer when installing on x64 In other words don't set the path for x64 installer on ARM64 * Remove postinstall script from hostfxr There should be no need for both the host and hostfxr to set the path to dotnet. Since the host installs dotnet, it should be the only package responsible for this. * Make postinstall set install_location on mac Also refactor script to use a template so that we don't need to fork the script. * fix some syntax errors in script * Update src/installer/pkg/sfx/installers/dotnet-host.proj Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Refine uname regular expressions Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Anipik pushed a commit
that referenced
this pull request
Sep 20, 2021
* Retarget DOTNETHOME when installing x64 on ARM64 (#58669) * Only set path in x64 mac installer when installing on x64 (#59210) * Only set path in x64 mac installer when installing on x64 In other words don't set the path for x64 installer on ARM64 * Remove postinstall script from hostfxr There should be no need for both the host and hostfxr to set the path to dotnet. Since the host installs dotnet, it should be the only package responsible for this. * Make postinstall set install_location on mac Also refactor script to use a template so that we don't need to fork the script. * fix some syntax errors in script * Update src/installer/pkg/sfx/installers/dotnet-host.proj Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Refine uname regular expressions Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Updating dependencies from https://github.com/dotnet/arcade build 20210917.3 Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In other words don't set the path for x64 installer on ARM64
I find it odd that both the host and hostfxfr write to path today. We could fix that if folks can say definitively if it is redundant. For now I unified the duplicate scripts (one was missing a bugifx to ensure
paths.dexisted).If we decide to have these scripts write to
/etc/dotnet/install_locationwe might want to change how we calculate "installer arch" and do that by applying a template at build time. I'm waiting to hear if we need to set that.