Skip to content

[Release/6.0]fix the package version for non-shipping csproj packages - #59369

Merged
Anipik merged 2 commits into
dotnet:release/6.0from
Anipik:packageVersion
Sep 21, 2021
Merged

[Release/6.0]fix the package version for non-shipping csproj packages#59369
Anipik merged 2 commits into
dotnet:release/6.0from
Anipik:packageVersion

Conversation

@Anipik

Copy link
Copy Markdown
Contributor

We override the Arcade package version with custom $(ServicingVersion) for each package, hence in some cases end up removing the version suffix
Version suffix is applied by the arcade whenever it is non-empty. Following the same convention here

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

We override the Arcade package version with custom $(ServicingVersion) for each package, hence in some cases end up removing the version suffix
Version suffix is applied by the arcade whenever it is non-empty. Following the same convention here

Author:Anipik
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@AnipikAnipik changed the title fix the package version for non-shipping csproj packages[Release/6.0]fix the package version for non-shipping csproj packagesSep 20, 2021
Comment threadeng/packaging.targets Outdated
@Anipik
Anipik merged commit da9d377 into dotnet:release/6.0Sep 21, 2021
@Anipik
Anipik deleted the packageVersion branch September 21, 2021 00:47
@Anipik

Copy link
Copy Markdown
ContributorAuthor

/backport to main

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to main: https://github.com/dotnet/runtime/actions/runs/1255743031

@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Anipik@ViktorHofer@safern