Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] [wasm][debugger] Reverting the old behavior of scope id numeration - #59372
Merged
Merged
Conversation
ghost
commented
Sep 20, 2021
Tagging subscribers to this area: @thaystg |
github-actionsBotforce-pushed
the
backport/pr-59368-to-release/6.0-rc2
branch
from
September 20, 2021 20:16
b586854 to
5ff671bComparelewing
approved these changes
Sep 20, 2021
lewing
commented
Sep 21, 2021
Member
approved in email |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59368 to release/6.0-rc2
/cc @thaystg
Customer Impact
When stepping into on console was showing a lot of messages like this:
fail: Microsoft.WebAssembly.Diagnostics.DevToolsProxy[0] sending error response for id: msg-B427C708D9E1C1FA369F37FF7BC6583A:::1025 -> [Result: IsOk: False, IsErr: True, Value: , Error: { "message": "Unable to RuntimeGetProperties 'dotnet:scope:48'" } ]Testing
Testing the case reported and it is fixed. Also added a unit test case.
Risk
Low risk, we are reverting the behavior that we had before about numeration of scopes.