Uh oh!
There was an error while loading. Please reload this page.
[release/6.0-rc2] [mono][wasm] Rework the handling of GC references in AOTed code. - #59397
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[release/6.0-rc2] [mono][wasm] Rework the handling of GC references in AOTed code.#59397github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Previously, variables holding GC refs were marked volatile so they were loaded/stored to the C stack on every access. Since the stack is conservatively scanned, all the objects pointed to by it are pinned, so there is no need to load them on every access. Instead of marking them as volatile, allocate a 'gc pinning' area on the stack, and store ref variables to it after they are assigned. This improves code size and performance.
github-actionsBot
requested review from
EgorBo, SamMonoRT, imhameed, lambdageek and vargaz
as code ownersSeptember 21, 2021 05:45
ghost
commented
Sep 21, 2021
Anipik
commented
Sep 27, 2021
Contributor
@marek-safar should we re-target this to 6.0 or is it blocking for rc2 ? |
lambdageek
commented
Sep 27, 2021
Member
@lewing ^ ? |
lewing
commented
Sep 27, 2021
Member
this definitely doesn't meet the rc2 bar at this point, it might be worth it for rtm but there is risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59352 to release/6.0-rc2
/cc @radical@vargaz
Customer Impact
Testing
Risk