Uh oh!
There was an error while loading. Please reload this page.
[mono] Disable partial generic sharing for gparams with non-enum constraints. - #59437
Merged
Conversation
vargaz
requested review from
SamMonoRT, imhameed and lambdageek
as code ownersSeptember 21, 2021 22:57
ghost
commented
Sep 21, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Sep 22, 2021
Tagging subscribers to 'arch-wasm': @lewing Issue Detailsnull
|
imhameed
approved these changes
Sep 23, 2021
lewing
commented
Sep 23, 2021
Member
@vargaz failures look potentially related |
vargazforce-pushed
the
gshared-enum-constraint
branch
from
September 23, 2021 23:14
87da8e3 to
61375c4Comparevargazforce-pushed
the
gshared-enum-constraint
branch
from
September 25, 2021 01:47
61375c4 to
7711006Compare…traints. If a generic argument is a primitive type, and it has an interface constraint that enums don't implement, then partial sharing for that instance is not useful, since only the specific primitive type instance will be able to use the shared version. Fixesdotnet#54910.
vargazforce-pushed
the
gshared-enum-constraint
branch
from
November 11, 2021 21:53
7711006 to
ab8e992Comparevargaz
commented
Nov 13, 2021
ContributorAuthor
There are no more failures, either they got fixed, or the failing lane was disabled: |
lewing
commented
Nov 14, 2021
Member
cc @steveisok for test data |
steveisok
commented
Nov 14, 2021
Member
We should merge and let the runtime tests run on the rolling build. |
steveisok
approved these changes
Nov 14, 2021
am11
commented
Nov 14, 2021
Member
This is because tests are disabled, opened: #61564. :) |
This was referenced Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.