Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Big-endian fixes: PDB creation by ilasm - #59452
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[release/6.0] Big-endian fixes: PDB creation by ilasm#59452github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
* Fix byte order of debug directory fields * Fix byte order of PDB stream data (PdbHeap::SetData)
ghost
commented
Sep 22, 2021
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #59422 to release/6.0 Customer ImpactTestingRisk
|
BruceForstall
commented
Sep 22, 2021
Contributor
@dotnet/jit-contrib PTAL |
jeffschwMSFT
approved these changes
Sep 22, 2021
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
Approved. We should take this for consideration in .NET 6.
AndyAyersMS
approved these changes
Sep 22, 2021
jeffschwMSFT
commented
Sep 27, 2021
Member
Closing as this was merged into RC2 via #59484 |
BruceForstall
commented
Sep 27, 2021
Contributor
@jeffschwMSFT Do rc2 changes automatically flow to the release branch? |
jeffschwMSFT
commented
Sep 27, 2021
Member
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59422 to release/6.0
/cc @BruceForstall@uweigand
Customer Impact
Fixes s390x platform source-build using .NET 6 tools. No impact to supported .NET 6 platforms.
Testing
Regular PR testing + ilasm/ildasm round-trip pri-1 test run.
Risk
Low.