Skip to content

[workloads] Use the dual signed wix version for workload msis - #59500

Merged
lewing merged 2 commits into
dotnet:mainfrom
lewing:wix-dual-signed
Oct 6, 2021
Merged

[workloads] Use the dual signed wix version for workload msis#59500
lewing merged 2 commits into
dotnet:mainfrom
lewing:wix-dual-signed

Conversation

@lewing

Copy link
Copy Markdown
Member

Fixes half of #59498

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes half of #59498

Author:lewing
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@lewinglewing changed the title Use the dual signed wix version for workload msis[workloads] Use the dual signed wix version for workload msisSep 22, 2021
@lewing

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0-rc2

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1263380417

@lewing

lewing commented Sep 23, 2021

Copy link
Copy Markdown
MemberAuthor

runtime (Libraries Test Run checked coreclr Linux_musl arm64 Release)
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-59500-merge-a1559d53be114c048e/System.Text.RegularExpressions.Tests/1/console.f989b822.log?sv=2019-07-07&se=2021-10-13T15%3A29%3A34Z&sr=c&sp=rl&sig=NhwXNpBox%2FCbd66qPzy%2FLXrtg%2BxxH6RSLzt6wPWde8E%3D

 Starting: System.Text.RegularExpressions.Tests (parallel test collections = on, max threads = 4)
System.Text.RegularExpressions.Tests.RegexMatchTests.Match_ExcessPrefix(engine: SourceGenerated) [FAIL]
Half-way through waiting for remote process.
Timed out at 9/23/2021 3:35:31 PM after 60000ms waiting for remote process.
Process ID: 263
Handle: 1880
Name: dotnet
MainModule: /root/helix/work/correlation/dotnet
StartTime: 9/23/2021 3:34:31 PM
TotalProcessorTime: 00:01:03.0900000
Stack Trace:
/_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(224,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose(Boolean disposing)
/_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(57,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose()
/_/src/libraries/System.Text.RegularExpressions/tests/Regex.Match.Tests.cs(1095,0): 

@lewing

lewing commented Sep 23, 2021

Copy link
Copy Markdown
MemberAuthor

@stephentoub several lanes here are failing due to the regex source generator tests. #59541

@ericstj

Copy link
Copy Markdown
Member

@lewing did you want to add #60008 to this PR as well?

@lewing

Copy link
Copy Markdown
MemberAuthor

@lewing did you want to add #60008 to this PR as well?

done

@ericstjericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericstj

Copy link
Copy Markdown
Member

Tested this manually by pulling over changes from dotnet/arcade#8000 and confirmed it works as expected.

@lewing
lewing merged commit 74ba133 into dotnet:mainOct 6, 2021
@lewing
lewing deleted the wix-dual-signed branch October 6, 2021 22:23
@ghostghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lewing@ericstj@steveisok@joeloff