Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix Time Zone when running with Globalization Invariant Mode - #59727
Merged
Conversation
ghost
commented
Sep 28, 2021
Tagging subscribers to this area: @tarekgh, @safern |
ghost
commented
Sep 28, 2021
Tagging subscribers to this area: @dotnet/area-system-runtime |
safern
approved these changes
Sep 28, 2021
danmoseley
approved these changes
Sep 28, 2021
tarekgh
commented
Sep 29, 2021
Member
The failure in |
tarekgh
commented
Sep 29, 2021
Member
@Anipik@ericstj@danmoseley looks I don't have permission to merge it. could you please help merging it? thanks! |
safern
commented
Sep 29, 2021
Member
@tarekgh done! |
tarekgh
commented
Sep 29, 2021
Member
Thanks @safern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59710 to release/6.0
Fixes#59636
/cc @tarekgh
Customer Impact
When enabling the globalization invariant mode on Linux, we'll always fallback to
UTCtime zone which is wrong and a regression from .NET 5.0. We have some docker containers (e.g. Alpine) which enable the globalization invariant mode by default on the whole image; the problem will be obvious there.In .NET 6.0 we have introduced the Globalization Invariant Mode Breaking Change. This breaking change causes throwing exception when enabling the globalization invariant mode and creating any culture other than Invariant culture.
If the globalization invariant mode is enabled and trying to get the local time zone when running on Linux platform, the creation process will try to initialize the display names of the time zone. This initialization tries to reset the UI culture to
en-USif it is set to Invariant culture. When we have the globalization invariant mode is on, the UI culture will always be Invariant and cause the time zone initialization to fallback toen-USwhich will throw exception because it is not allowed to create any other cultures in the Invariant mode. We catch the exception and then fallback to useUTCtime zone instead of the actual time zone set on the running machine.Testing
Manually tested, added a test to fill the gap in testing time zone with the globalization invariant mode, and passing the regression tests and CI run on main branch.
Risk
Low as not changing any logic more than checking for invariant mode and avoid try creating cultures which cause exception throwing. We are back to .NET 5.0 behavior.