Skip to content

[release/6.0] Define SystemReflectionMetadataStaticVersion to workaround source-build issues. - #59782

Merged
Anipik merged 1 commit into
dotnet:release/6.0from
MichaelSimons:patch-backport-58800
Sep 30, 2021
Merged

[release/6.0] Define SystemReflectionMetadataStaticVersion to workaround source-build issues.#59782
Anipik merged 1 commit into
dotnet:release/6.0from
MichaelSimons:patch-backport-58800

Conversation

@MichaelSimons

Copy link
Copy Markdown
Member

This fixes the underlying issue that manifested itself as #58800.

The core issue is that when building in source-build, the SystemReflectionMetadataVersion gets overridden to the source-built version (6.0) which causes assembly resolution issues impacting crossgen2. The long term solution is a 7.0 source-build feature which would eliminate the SystemReflectionMetadataVersion override because the dependency is not defined in the repo's Version.Details.xml file.

@MichaelSimons

Copy link
Copy Markdown
MemberAuthor

cc @dseefeld

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes the underlying issue that manifested itself as #58800.

The core issue is that when building in source-build, the SystemReflectionMetadataVersion gets overridden to the source-built version (6.0) which causes assembly resolution issues impacting crossgen2. The long term solution is a 7.0 source-build feature which would eliminate the SystemReflectionMetadataVersion override because the dependency is not defined in the repo's Version.Details.xml file.

Author:MichaelSimons
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@MichaelSimons

Copy link
Copy Markdown
MemberAuthor

@ViktorHofer - Can you tell me what ask/tell mode policies apply to this change? Thanks.

@ViktorHoferViktorHofer changed the title Define SystemReflectionMetadataStaticVersion to prevent source-build from building w/6.0 version.[release/6.0] Define SystemReflectionMetadataStaticVersion to prevent source-build from building w/6.0 version.Sep 30, 2021
@ViktorHofer

Copy link
Copy Markdown
Member

I'm not sure myself as this is a necessary change to ship .NET 6 built from source. @danmoseley would you know?

@danmoseley

Copy link
Copy Markdown
Contributor

"Necessary infra changes to ship" is tell mode to tactics

@MichaelSimonsMichaelSimons changed the title [release/6.0] Define SystemReflectionMetadataStaticVersion to prevent source-build from building w/6.0 version.[release/6.0] Define SystemReflectionMetadataStaticVersion to get source-build building.Sep 30, 2021
@MichaelSimonsMichaelSimons changed the title [release/6.0] Define SystemReflectionMetadataStaticVersion to get source-build building.[release/6.0] Define SystemReflectionMetadataStaticVersion to workaround source-build issues.Sep 30, 2021
@Anipik
Anipik merged commit 23a5153 into dotnet:release/6.0Sep 30, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MichaelSimons@ViktorHofer@danmoseley@Anipik