Skip to content

JIT: fix register arg size computation for OSR - #59789

Merged
AndyAyersMS merged 2 commits into
dotnet:mainfrom
AndyAyersMS:OSREmitTypeFix
Oct 1, 2021
Merged

JIT: fix register arg size computation for OSR#59789
AndyAyersMS merged 2 commits into
dotnet:mainfrom
AndyAyersMS:OSREmitTypeFix

Conversation

@AndyAyersMS

@AndyAyersMSAndyAyersMS commented Sep 30, 2021

Copy link
Copy Markdown
Member

OSR methods must do special setups for register parameters, loading them
from the original method's frame. Update the computation we do here so it
works for TYP_STRUCT register params.

Closes#59875.

@AndyAyersMS
JIT: fix register arg size computation for OSR
f2a059c
OSR methods must do special setups for register parameters, loading them
from the original method's frame. Update the computation we do here so it
works for TYP_STRUCT register params.
Closesdotnet#59875.
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 30, 2021
@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

OSR methods must do special setups for register parameters, loading them
from the original method's frame. Update the computation we do here so it
works for TYP_STRUCT register params.

Closes #59875.

Author:AndyAyersMS
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@AndyAyersMS

AndyAyersMS commented Sep 30, 2021

Copy link
Copy Markdown
MemberAuthor

cc @dotnet/jit-contrib

kunalspathak
kunalspathak approved these changes Sep 30, 2021
View reviewed changes

@kunalspathakkunalspathak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyAyersMS

AndyAyersMS commented Sep 30, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-jit-experimental

@azure-pipelines

azure-pipelinesBot commented Sep 30, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMSAndyAyersMS mentioned this pull request Sep 30, 2021
Merged
jakobbotsch
jakobbotsch reviewed Sep 30, 2021
View reviewed changes
Comment threadsrc/coreclr/jit/codegencommon.cpp
@AndyAyersMS

AndyAyersMS commented Sep 30, 2021

Copy link
Copy Markdown
MemberAuthor

OSR stress R2R tests are all failing with various internal errors.

Same failures are there in last weekend's runs so it must be some other problem

@AndyAyersMS

AndyAyersMS commented Sep 30, 2021

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-jit-experimental

@azure-pipelines

azure-pipelinesBot commented Sep 30, 2021

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@AndyAyersMS

AndyAyersMS commented Oct 1, 2021

Copy link
Copy Markdown
MemberAuthor

The crossgen2 test failure is the same issue, it's just cropping up in the dotnet used to run crossgen2, which is currently 6.0.100-rc.1.21430.12.

That is, we're running crossgen2 under OSR stress, using an older version of the jit, that still has this bug. Running the test where the crossgen2 is an updated corerun passes.

So this will fix itself eventually, once we update that set of bits.

@AndyAyersMS
AndyAyersMS merged commit 646e195 into dotnet:mainOct 1, 2021
@AndyAyersMS
AndyAyersMS deleted the OSREmitTypeFix branch October 1, 2021 01:00
@jkoritzinskyjkoritzinsky mentioned this pull request Oct 2, 2021
Closed
@ghostghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
+1 more reviewer
@kunalspathakkunalspathakkunalspathak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cache compaction will never start

3 participants

@AndyAyersMS@jakobbotsch@kunalspathak