Skip to content

[release/6.0][wasm] Fix codeql checks - #59839

Merged
steveisok merged 3 commits into
dotnet:release/6.0from
lewing:release-codeql
Oct 6, 2021
Merged

[release/6.0][wasm] Fix codeql checks#59839
steveisok merged 3 commits into
dotnet:release/6.0from
lewing:release-codeql

Conversation

@lewing

@lewinglewing commented Sep 30, 2021

Copy link
Copy Markdown
Member

Fixes#59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.

Customer Impact

Avoids scanning errors in the shipped javascript.

Testing

Manual

Risk

Tiny

@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@lewinglewing changed the title [release/6.0] Fix codeql checks[release/6.0][wasm] Fix codeql checksSep 30, 2021
@lewinglewing mentioned this pull request Sep 30, 2021
Closed
@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.

Customer Impact

Avoids scanning errors in the shipped javascript.

Testing

Manual

Risk

Tiny

Author:lewing
Assignees:-
Labels:

area-Infrastructure-mono

Milestone:-

@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown

Tagging subscribers to this area:
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #59147 for release/6.0 a console method is called
with both a concatenated format string and multiple arguments.

Customer Impact

Avoids scanning errors in the shipped javascript.

Testing

Manual

Risk

Tiny

Author:lewing
Assignees:-
Labels:

area-VM-meta-mono

Milestone:-

kg
kg suggested changes Oct 1, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/library_mono.js Outdated
kg
kg suggested changes Oct 1, 2021
View reviewed changes
Comment threadsrc/mono/wasm/runtime/library_mono.js Outdated
@lewing
lewing requested a review from kgOctober 1, 2021 15:26
@lewing
Update library_mono.js
e435fa9
and fix the other typo
kg
kg approved these changes Oct 1, 2021
View reviewed changes
@lewinglewing added Servicing-consider Issue for next servicing release review Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 6, 2021
@lewing

lewing commented Oct 6, 2021

Copy link
Copy Markdown
MemberAuthor

approved in email

@lewinglewing added this to the 6.0.0 milestone Oct 6, 2021
@steveisok
steveisok merged commit 5e9e865 into dotnet:release/6.0Oct 6, 2021
@lewing
lewing deleted the release-codeql branch October 7, 2021 01:12
@ghostghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SteveSandersonMSSteveSandersonMSAwaiting requested review from SteveSandersonMS
@marek-safarmarek-safarAwaiting requested review from marek-safarmarek-safar is a code owner
@blowdartblowdartAwaiting requested review from blowdart
1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-VM-meta-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lewing@kg@steveisok