Add back the nethost archive. - #59847

Merged

jkoritzinsky merged 12 commits into

dotnet:mainfrom

jkoritzinsky:nethost-archive

Oct 5, 2021

jkoritzinsky commented Sep 30, 2021

Member

This archive makes it a bit easier for developers to pull down nethost in a non-.NET environment (without NuGet). We had this in 3.1, but it was lost at some point between then and now with all of the large infrastructure changes.

With #59842, fixes#49026

cc: @vitek-karas @AaronRobinsonMSFT @elinor-fung should we backport this to 6.0 (aka do we feel that shipping the nethost archive in 6.0 is important enough to backport)

Add back the nethost archive.

c3b6ce9

This archive makes it a bit easier for developers to pull down nethost in a non-.NET environment (without NuGet). We had this in 3.1, but it was lost at some point between then and now with all of the large infrastructure changes.

jkoritzinsky added the area-Setup label

jkoritzinsky added this to the 7.0.0 milestone

jkoritzinsky requested a review from a team

September 30, 2021 23:50

AaronRobinsonMSFT commented Oct 1, 2021

Member

I think this is .NET 6 worthy. It would be good to have a solid argument though. I think source-build is enough but make sure that is known.

AaronRobinsonMSFT reviewed

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

jkoritzinsky added 2 commits

September 30, 2021 17:16

Fix symbols copying.

e9b8c53

Create the symbols archive for nethost

224755e

hoyosjs reviewed

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

runfoappBot mentioned this pull request

System.Threading.Tests.PeriodicTimerTests.PeriodicTimer_ActiveOperations_TimerRooted failing in CI #59542

Closed

Update src/installer/pkg/archives/dotnet-nethost.proj

b8ff86a

Co-authored-by: Juan Hoyos <19413848+hoyosjs@users.noreply.github.com>

elinor-fung reviewed

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

Update src/installer/pkg/archives/dotnet-nethost.proj

d2f2ac0

Co-authored-by: Elinor Fung <elfung@microsoft.com>

jkoritzinsky commented

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

Update src/installer/pkg/archives/dotnet-nethost.proj

43160c3

vitek-karas commented Oct 1, 2021

Member

Would be nice to have this for 6.0. But since this is fully backward compatible, people can use 7.0 builds just as well.

jkoritzinsky added 2 commits

October 1, 2021 11:32

Symbols are in the PDB folder.

d038f52

Fix symbol paths for xplat.

8898ead

jkoritzinsky commented

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

Update src/installer/pkg/archives/dotnet-nethost.proj

20fb630

runfoappBot mentioned this pull request

'The "Microsoft.DotNet.Compatibility.ValidatePackage" task failed unexpectedly' in libs legs #59908

Closed

jkoritzinsky commented Oct 4, 2021

MemberAuthor

All CI failures are due to #59908. This PR is ready for another round of review

ViktorHofer reviewed

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

ViktorHofer reviewed

View reviewed changes

src/installer/pkg/archives/Directory.Build.props

ViktorHofer reviewed

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj

ViktorHofer reviewed

View reviewed changes

src/installer/pkg/archives/dotnet-nethost.proj Outdated

jkoritzinskyand others added 3 commits

October 5, 2021 09:28

Update src/installer/pkg/archives/dotnet-nethost.proj

b581c3a

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

Update src/installer/pkg/archives/dotnet-nethost.proj

b860c22

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>

Merge branch 'main' into nethost-archive

2b94668

ViktorHofer approved these changes

View reviewed changes

jkoritzinsky merged commit 01fdc90 into dotnet:main

jkoritzinsky deleted the nethost-archive branch

October 5, 2021 20:08

ghost locked as resolved and limited conversation to collaborators

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.