Uh oh!
There was an error while loading. Please reload this page.
Re-enable Windows test that verifies DriveInfo.VolumeLabel setter fails on SUBST'd drive - #59850
Conversation
ghost
commented
Oct 1, 2021
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsFixes #14027 I'm reusing code I recently added to verify SUBST with symbolic links. I moved it to its own class for virtual drive manipulation on Windows.
|
Investigating this failure. I don't know why it is happening in x64 Windows Debug, since it's the one I tested locally: Edit: Ah, I think it's the Net5Compat test project. |
adamsitnik
commented
Nov 8, 2021
@carlossanlop could you solve the conflict? |
carlossanlop
commented
Nov 24, 2021
@jozkee@adamsitnik sorry for the delay. I resolved the conflict: Net5Compat has been recently removed, and that project was also the source of the CI failure. Can you please take a look again? |
Edit: I opened issue #62028 The CI leg |
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, I left some comments but they're all related to refactoring ideas. Thank you @carlossanlop !
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
nit: you can provide multiple parameters to Combine and avoid the need of having an additional local variable
| stringsystem32=Path.Join(systemRoot,"System32"); | |
| returnPath.Join(system32,"subst.exe"); | |
| returnPath.Join(systemRoot,"System32","subst.exe"); |
There was a problem hiding this comment.
You know, this could be an interesting candidate for a Roslyn Analyzer.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fixes#14027
I'm reusing code I recently added to verify SUBST with symbolic links. I moved it to its own class for virtual drive manipulation on Windows.