Uh oh!
There was an error while loading. Please reload this page.
Fix code heap reservation size - #59883
Merged
Merged
Conversation
When I've moved the heap metadata out of the actual code heaps some time ago, I've forgotten to account for the personality routine slot allocated at the beginning of the heaps. This was exposed by an assert when executing under the JIT stress mode 2. This change fixes it by adding accounting for those. Closedotnet#59794
janvorli
commented
Oct 1, 2021
MemberAuthor
cc: @BruceForstall |
jkotas
approved these changes
Oct 1, 2021
jkotas
commented
Oct 1, 2021
Member
Do we need to port this to 6.0? |
BruceForstall
commented
Oct 1, 2021
Contributor
Thanks for the quick fix!
IMO, seems like we should. At least the fix is simple. |
janvorli
commented
Oct 4, 2021
MemberAuthor
/backport to release/6.0 |
Contributor
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1302636674 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I've moved the heap metadata out of the actual code heaps some time
ago, I've forgotten to account for the personality routine slot
allocated at the beginning of the heaps. This was exposed by an assert when
executing under the JIT stress mode 2.
This change fixes it by adding accounting for those.
Close#59794