Skip to content

[mono] Implement coreclr_create_delegate and move ComponentActivator to shared CoreLib - #59962

Merged
lambdageek merged 4 commits into
dotnet:mainfrom
lambdageek:component-activator-in-mono
Oct 6, 2021
Merged

[mono] Implement coreclr_create_delegate and move ComponentActivator to shared CoreLib#59962
lambdageek merged 4 commits into
dotnet:mainfrom
lambdageek:component-activator-in-mono

Conversation

@lambdageek

@lambdageeklambdageek commented Oct 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member
  • Implements the coreclr_create_delegate hosting API for MonoVM
  • Moves the ComponentActivator internal classes to the shared CoreLib area
  • Only works on desktop, and with trimming disabled.

Contributes to #59815

Tested with https://github.com/lambdageek/dnne_monovm_sample

@ghost

ghost commented Oct 4, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

lambdageek
lambdageek commented Oct 4, 2021
View reviewed changes
Comment threadsrc/mono/mono/mini/monovm.c Outdated
Comment on lines 355 to 358

@lambdageeklambdageekOct 4, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vargaz I'm not sure if need to call mono_get_addr_from_ftnptr here or not.

AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Oct 4, 2021
View reviewed changes

@AaronRobinsonMSFTAaronRobinsonMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment threadsrc/mono/mono/mini/monovm.h Outdated
Comment threadsrc/mono/mono/mini/monovm.c Outdated
Comment threadsrc/mono/mono/mini/monovm.c Outdated
@lambdageek
lambdageekforce-pushed the component-activator-in-mono branch from 427bd72 to 25f55a7CompareOctober 4, 2021 20:16
lambdageek
lambdageek commented Oct 4, 2021
View reviewed changes
Comment threadsrc/tasks/WasmAppBuilder/PInvokeTableGenerator.cs Outdated
@lambdageek
lambdageekforce-pushed the component-activator-in-mono branch from 9ff16db to 0ee0d0aCompareOctober 5, 2021 14:09
steveisok
steveisok approved these changes Oct 6, 2021
View reviewed changes

@steveisoksteveisok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lambdageek
lambdageek merged commit b393a43 into dotnet:mainOct 6, 2021
@ghostghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT left review comments
@steveisoksteveisoksteveisok approved these changes
@imhameedimhameedAwaiting requested review from imhameed
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
@vargazvargazAwaiting requested review from vargaz
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
@vitek-karasvitek-karasAwaiting requested review from vitek-karasvitek-karas is a code owner

Assignees

No one assigned

Labels

area-Interop-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lambdageek@steveisok@AaronRobinsonMSFT