Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] Fix byte array handling in STJ sourcegen - #60004
Merged
Conversation
github-actionsBot
requested review from
eiriktsarpalis, layomia and steveharter
as code ownersOctober 5, 2021 16:27
ghost
commented
Oct 5, 2021
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsBackport of #59957 to release/6.0 /cc @eiriktsarpalis Customer ImpactTestingRisk
|
eiriktsarpalis
approved these changes
Oct 5, 2021
danmoseley
commented
Oct 6, 2021
Contributor
approved in mail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #59957 to release/6.0
/cc @eiriktsarpalis
Customer Impact
Fixes a bug where STJ sourcegen would incorrectly serialize
byte[]instances as JSON arrays of numbers. This diverges from the default behavior of the reflection-based serializer which representsbyte[]as Base64 encoded strings. It is currently not possible to roundtrip data written with the v5 reflection serializer. This is a customer reported issue.Testing
Added tests validating the correct behavior.
Risk
Low. Makes minor interventions in product code that specifically addresses byte array Roslyn type symbol resolution.