Skip to content

Convert concatenation string to interpolation for System.Private.Xml - #60057

Merged
eiriktsarpalis merged 17 commits into
dotnet:mainfrom
kronic:Convert_concatenation_to_interpolation
Nov 9, 2021
Merged

Convert concatenation string to interpolation for System.Private.Xml#60057
eiriktsarpalis merged 17 commits into
dotnet:mainfrom
kronic:Convert_concatenation_to_interpolation

Conversation

@kronic

@kronickronic commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@ghostghost added community-contribution Indicates that the PR has been added by a community member area-System.Xml labels Oct 6, 2021
@ghost

ghost commented Oct 6, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:kronic
Assignees:-
Labels:

area-System.Xml, community-contribution

Milestone:-

krwq
krwq reviewed Oct 6, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Dom/DocumentXmlWriter.cs Outdated
@kronic
kronic requested a review from krwqOctober 6, 2021 09:14
am11
am11 reviewed Oct 6, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/ImportContext.cs Outdated
@runfoapprunfoappBot mentioned this pull request Oct 6, 2021
Closed
@kronickronic closed this Oct 18, 2021
@eiriktsarpalis

eiriktsarpalis commented Oct 18, 2021

Copy link
Copy Markdown
Member

Hi @kronic, curious why the PR was closed?

@kronickronic reopened this Oct 18, 2021
@kronic

kronic commented Oct 18, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@eiriktsarpalis Hello, closed by mistake

eiriktsarpalis
eiriktsarpalis approved these changes Oct 19, 2021
View reviewed changes

@eiriktsarpaliseiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although might need another pair of eyes.

@runfoapprunfoappBot mentioned this pull request Oct 20, 2021
Closed
@kronic

kronic commented Oct 27, 2021

Copy link
Copy Markdown
ContributorAuthor

ping @eiriktsarpalis@krwq

stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Core/XmlTextWriter.cs Outdated

@stephentoubstephentoubNov 5, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return$"d{_top.ToString("d",CultureInfo.InvariantCulture)}p{temp.ToString("d",CultureInfo.InvariantCulture)}";
returnstring.Create(CultureInfo.InvariantCulture,$"d{_top}p{temp}";

@kronickronicNov 8, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephentoub maybe

string.Create(CultureInfo.InvariantCulture,$"d{_top:d}p{temp:d}";

stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/Compiler.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSchemaExporter.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSchemas.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReader.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReader.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriter.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriter.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Xsl/QIL/QilValidationVisitor.cs Outdated
stephentoub
stephentoub reviewed Nov 5, 2021
View reviewed changes
Comment threadsrc/libraries/System.Private.Xml/src/System/Xml/Xsl/Runtime/XmlQueryOutput.cs Outdated
@kronic

kronic commented Nov 8, 2021

Copy link
Copy Markdown
ContributorAuthor

@stephentoub ping

@eiriktsarpalis
eiriktsarpalisforce-pushed the Convert_concatenation_to_interpolation branch from a3a0ec8 to 82feb68CompareNovember 8, 2021 12:56
@eiriktsarpalis

eiriktsarpalis commented Nov 9, 2021

Copy link
Copy Markdown
Member

Thank you @kronic!

@eiriktsarpalis
eiriktsarpalis merged commit 08aff10 into dotnet:mainNov 9, 2021
@kronic
kronic deleted the Convert_concatenation_to_interpolation branch November 9, 2021 11:40
This was referenced Nov 29, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoubstephentoubstephentoub approved these changes
@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@krwqkrwqAwaiting requested review from krwq
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Xmlcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kronic@eiriktsarpalis@krwq@stephentoub@am11@buyaa-n