Uh oh!
There was an error while loading. Please reload this page.
[wasm][debugger] Avoid using Uint8Array to set memory content - #60087
Conversation
But I'm not using Uint8Array to set the content on memory allocated using malloc as @lewing suggested in the same PR.
ghost
commented
Oct 6, 2021
Tagging subscribers to this area: @thaystg |
ghost
commented
Oct 6, 2021
Tagging subscribers to 'arch-wasm': @lewing |
Uh oh!
There was an error while loading. Please reload this page.
kg
left a comment
There was a problem hiding this comment.
Looks fine, and you can do the single malloc like before if you want
| } | ||
| [Fact] | ||
| public async Task MallocUntilReallocate() //https://github.com/xamarin/xamarin-android/issues/6161 |
There was a problem hiding this comment.
- Should this maybe pause/inspect/resume through one breakpoint first, then call
malloc_to_reallocate_test, and then try the breakpoint again? - Can we add something in the test to confirm that the memory grew?
There was a problem hiding this comment.
- Why it would be good to test a breakpoint first? I think it's not necessary, if I remove the fix on [wasm][debugger] Fix reusing buffer for debugger #59773, I can perfectly reproduce the behavior that we were getting when debugging from VS.
- I'm not sure, I'll try to find a way to detect it.
There was a problem hiding this comment.
- Why it would be good to test a breakpoint first?
I was thinking that it would ensure that the debugger buffer had been used at least once. But that would get used to even get started with debugging, IIUC, so you are correct - this isn't needed 👍
- I'm not sure, I'll try to find a way to detect it.
Maybe even a simple - UInt8Array before the growth, and then checking that it got reset?
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Creating a test case for PR #59773
But I'm not using Uint8Array to set the content on memory allocated using malloc as @lewing suggested in the same PR.