Skip to content

Infra for regeneration of third-party-notices file - #60091

Merged
NikolaMilosavljevic merged 7 commits into
dotnet:mainfrom
NikolaMilosavljevic:tpn.infra
Mar 25, 2022
Merged

Infra for regeneration of third-party-notices file#60091
NikolaMilosavljevic merged 7 commits into
dotnet:mainfrom
NikolaMilosavljevic:tpn.infra

Conversation

@NikolaMilosavljevic

@NikolaMilosavljevicNikolaMilosavljevic commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

This is based on infra originally implemented by @dagooddagood/core-setup@bac3b0d...100d6dc

It regenerates TPN file under src/installer/pkg, with content from dotnet/runtime and other repos. We used the same infra for .NET 5 release, but it was never merged into runtime repo.

@ghost

ghost commented Oct 6, 2021

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@NikolaMilosavljevicNikolaMilosavljevic mentioned this pull request Oct 6, 2021
Merged
dagood
dagood reviewed Oct 6, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
@NikolaMilosavljevic@dagood
Update eng/regenerate-third-party-notices.proj
3c4f99c
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
@runfoapprunfoappBot mentioned this pull request Oct 7, 2021
Closed
am11
am11 reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
am11
am11 reviewed Oct 7, 2021
View reviewed changes
Comment threadsrc/tasks/installer.tasks/StaticFileRegeneration/RegenerateThirdPartyNotices.cs
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadeng/Subsets.props Outdated
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadsrc/tasks/installer.tasks/StaticFileRegeneration/RegenerateThirdPartyNotices.cs Outdated
@runfoapprunfoappBot mentioned this pull request Oct 7, 2021
Closed
ViktorHofer
ViktorHofer reviewed Oct 7, 2021
View reviewed changes
Comment threadsrc/tasks/installer.tasks/StaticFileRegeneration/TpnDocument.cs Outdated
akoeplinger
akoeplinger reviewed Oct 14, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj Outdated
@NikolaMilosavljevic

NikolaMilosavljevic commented Nov 11, 2021

Copy link
Copy Markdown
ContributorAuthor

@dagood@akoeplinger is this now good for merging? I'm waiting on one approving review.

akoeplinger
akoeplinger approved these changes Nov 11, 2021
View reviewed changes
Comment threadeng/regenerate-third-party-notices.proj
<TpnRepo Include="dotnet/wpf" />

<!--
Additional repos that should be included but don't have any third-party-notices files:

@akoeplingerakoeplingerNov 11, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue which tracks adding these repos?

dotnet/emsdk would be another one.

@NikolaMilosavljevicNikolaMilosavljevicNov 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I've added this repo and created the tracking issue: #61466

@NikolaMilosavljevicNikolaMilosavljevic mentioned this pull request Nov 11, 2021
Closed
7 tasks
@danmoseley

danmoseley commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

@NikolaMilosavljevic is this ok to merge now?

@danmoseley

danmoseley commented Mar 23, 2022

Copy link
Copy Markdown
Contributor

@NikolaMilosavljevic is this OK to merge? or else we should close it.

@danmoseleydanmoseley reopened this Mar 23, 2022
@NikolaMilosavljevic

NikolaMilosavljevic commented Mar 23, 2022

Copy link
Copy Markdown
ContributorAuthor

@danmoseley I'll need to verify that this still works fine with potential infra changes that happened in the meantime.

@NikolaMilosavljevic
NikolaMilosavljevic merged commit ca8ddae into dotnet:mainMar 25, 2022
@NikolaMilosavljevic

NikolaMilosavljevic commented Mar 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Verified that infra is still compatible with original changes. TPNs can be regenerated with a simple command: build -subset RegenerateThirdPartyNotices

@danmoseley

danmoseley commented Mar 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @NikolaMilosavljevic !

radekdoulik pushed a commit to radekdoulik/runtime that referenced this pull request Mar 30, 2022
@NikolaMilosavljevic@dagood@radekdoulik
Infra for regeneration of third-party-notices file (dotnet#60091)
ed6a52c
* Infra for regeneration of third-party-notices file
* Update eng/regenerate-third-party-notices.proj
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
* Addressing PR comments
* Updated copyright in all .cs files
* Update dotnet/liner repo name
* Add dotnet/emsdk to the list
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
@ghostghost locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ViktorHoferViktorHoferViktorHofer left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
@dagooddagooddagood approved these changes
@hoyosjshoyosjsAwaiting requested review from hoyosjs
@jkoritzinskyjkoritzinskyAwaiting requested review from jkoritzinsky
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Infrastructure-installer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@NikolaMilosavljevic@danmoseley@akoeplinger@am11@ViktorHofer@dagood