Skip to content

Fix TimeZones Test failure - #60140

Merged
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:FixTimeZoneFailingTest
Oct 7, 2021
Merged

Fix TimeZones Test failure#60140
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:FixTimeZoneFailingTest

Conversation

@tarekgh

Copy link
Copy Markdown
Member

Fixes#60119

Recently, Helix started to use Windows 7 N image in the CI run. This image includes a lot of installed UI languages. The time zone display names depends on the installed localized resources on the path %SystemDirectory%\[Language]\tzres.dll.mui. For example, if Japanese UI language is installed, Windows will install the file %SystemDirectory%\ja-JP\tzres.dll.mui. We found on the Windows 7 image, Windows not necessary installing this file for specific language. zh-HK is the one we encountered which caused the test failure.

The fix here is to make the test tolerate this case. The test still working properly and validating all installed UI languages time zone display names.

@ghost

ghost commented Oct 7, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @tarekgh, @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60119

Recently, Helix started to use Windows 7 N image in the CI run. This image includes a lot of installed UI languages. The time zone display names depends on the installed localized resources on the path %SystemDirectory%\[Language]\tzres.dll.mui. For example, if Japanese UI language is installed, Windows will install the file %SystemDirectory%\ja-JP\tzres.dll.mui. We found on the Windows 7 image, Windows not necessary installing this file for specific language. zh-HK is the one we encountered which caused the test failure.

The fix here is to make the test tolerate this case. The test still working properly and validating all installed UI languages time zone display names.

Author:tarekgh
Assignees:-
Labels:

area-System.Globalization

Milestone:-

@ghost

ghost commented Oct 7, 2021

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #60119

Recently, Helix started to use Windows 7 N image in the CI run. This image includes a lot of installed UI languages. The time zone display names depends on the installed localized resources on the path %SystemDirectory%\[Language]\tzres.dll.mui. For example, if Japanese UI language is installed, Windows will install the file %SystemDirectory%\ja-JP\tzres.dll.mui. We found on the Windows 7 image, Windows not necessary installing this file for specific language. zh-HK is the one we encountered which caused the test failure.

The fix here is to make the test tolerate this case. The test still working properly and validating all installed UI languages time zone display names.

Author:tarekgh
Assignees:-
Labels:

area-System.Runtime

Milestone:-

@tarekghtarekgh added this to the 7.0.0 milestone Oct 7, 2021
@tarekgh

Copy link
Copy Markdown
MemberAuthor

CC @MattGal@krwq@safern

Comment threadsrc/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs Outdated

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarekgh

Copy link
Copy Markdown
MemberAuthor

runtime (Libraries Test Run release coreclr windows x86 Debug) failure is unrelated and tracked by the issue #60147

@tarekgh
tarekgh merged commit eff8883 into dotnet:mainOct 7, 2021
@tarekgh
tarekgh deleted the FixTimeZoneFailingTest branch October 7, 2021 23:28
@tarekgh

Copy link
Copy Markdown
MemberAuthor

/backport to release/6.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1318301449

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System.Tests.TimeZoneInfoTests.TestWindowsNlsDisplayNames is failing on rolling builds

5 participants

@tarekgh@danmoseley@MattGal@safern@jeffhandley