Skip to content

CI matrix update: add Ubuntu 21.04 - second attempt - #60162

Merged
aik-jahoda merged 3 commits into
mainfrom
jajahoda/matrixubuntu2104
Dec 9, 2021
Merged

CI matrix update: add Ubuntu 21.04 - second attempt#60162
aik-jahoda merged 3 commits into
mainfrom
jajahoda/matrixubuntu2104

Conversation

@aik-jahoda

Copy link
Copy Markdown
Contributor

The original CI matrix change was reverted (#60040) because of a failing CI.

part of #57947

original PR: #59578

@ViktorHofer

ViktorHofer commented Oct 25, 2021

Copy link
Copy Markdown
Member

Same comment as in your other PR:

I didn't check the yml. Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected?

@hoyosjs

Copy link
Copy Markdown
Member

Same comment as in your other PR:

I didn't check the yml. Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected?

As it stands now - it would only run in a rolling build

@aik-jahodaaik-jahoda reopened this Nov 25, 2021
@aik-jahoda
aik-jahoda removed the request for review from AnipikNovember 29, 2021 13:57
@karelz

Copy link
Copy Markdown
Member

@safern@ericstj can you please review the PR? Then we can merge (and backport to .NET 6.0). Thanks!

@karelz
karelz requested a review from ericstjNovember 29, 2021 15:56
@ericstj

Copy link
Copy Markdown
Member

I believe there is an open question from reviewers above which requires attention:

Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected?

As it stands now - it would only run in a rolling build

@aik-jahoda Can you share the results of the rolling build which tests your changes?

@aik-jahoda

Copy link
Copy Markdown
ContributorAuthor

@aik-jahoda

Copy link
Copy Markdown
ContributorAuthor

@safern, @ericstj , can you please take a look?

@ericstjericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @safern do you agree?

@ericstj

Copy link
Copy Markdown
Member

Actually, I'm not entirely certain how to interpret all these failures in the other legs. I see the linked log shows at least one pass on the new queues. Do you understand the other failures?

@safernsafern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@aik-jahoda
aik-jahoda merged commit 546e517 into mainDec 9, 2021
@karelzkarelz added this to the 7.0.0 milestone Dec 9, 2021
@safern
safern deleted the jajahoda/matrixubuntu2104 branch December 10, 2021 21:48
@ghostghost locked as resolved and limited conversation to collaborators Jan 10, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aik-jahoda@ViktorHofer@hoyosjs@karelz@ericstj@safern