Skip to content

CI matrix change: add Windows Server 2022 - #60163

Closed
aik-jahoda wants to merge 6 commits into
mainfrom
jajahoda/cimatrix2022
Closed

CI matrix change: add Windows Server 2022#60163
aik-jahoda wants to merge 6 commits into
mainfrom
jajahoda/cimatrix2022

Conversation

@aik-jahoda

@aik-jahodaaik-jahoda commented Oct 8, 2021

Copy link
Copy Markdown
Contributor
OSWhat to doNotes
Windows Server 2022Add rolling

part of #57947

This PR changes ssl detection for test for older ssl version

Comment threadsrc/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated
Comment threadsrc/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated
Comment threadsrc/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated
Comment threadsrc/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated
Comment threadsrc/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated
Comment threadsrc/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs Outdated
@aik-jahoda

Copy link
Copy Markdown
ContributorAuthor

@wfurt, this PR change ssl detection for test. Can you review if this change is reasonable?

@aik-jahoda
aik-jahoda requested a review from a teamNovember 29, 2021 14:27

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection changes look ok to me. I like the idea of establishing clear default and generalizing the code.

@ericstj

Copy link
Copy Markdown
Member

Looks like this may have been superseded by #64827

@safern@wfurt do we need the PlatofrmDetection changes from this PR? cc @karelz

@safern

Copy link
Copy Markdown
Member

Libraries test runs on Windows on my PR were green, so I'd imagine we no longer need this for some reason? I
ll let @wfurt confirm.

@wfurt

wfurt commented Feb 7, 2022

Copy link
Copy Markdown
Member

I think the detection part is valuable. There is push to disable Tls1.0 and Tls1.1 on Azure machines. While we dodged it for now (hopefully) that day may come so as other can run into it on their machines.

@safern

Copy link
Copy Markdown
Member

@wfurt would you mind taking care of that?

@safernsafern closed this Feb 7, 2022
@wfurtwfurt mentioned this pull request Feb 7, 2022
@akoeplinger
akoeplinger deleted the jajahoda/cimatrix2022 branch February 12, 2022 00:22
@ghostghost locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@aik-jahoda@ericstj@safern@wfurt@danmoseley@carlossanlop